Fix AWS Health Event Bridge Rule #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AustinSiu
reviewed
Apr 26, 2022
|
/lgtm 👍 |
AustinSiu
approved these changes
Apr 28, 2022
|
this PR missed also updating the cfn sample:
aws-node-termination-handler/README.md Line 340 in 82f3a25 vs aws-node-termination-handler/docs/cfn-template.yaml Lines 35 to 42 in 82f3a25 |
|
Thank you @vincentgna for noticing it, will update cfn sample as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #550
Description of changes:
Modified the Event Bridge Rule for "MyK8sScheduledChangeRule" in README document to consider the detail-type for the AWS Health Events.
Modified the conditions in "scheduled-change-event" file for checking service and event type category for AWS Health Events. Instead of returning an error, now it returns a warning message and deletes the messages that are not handled by NTH.
For testing the changes, followed the below steps:
- Ran the e2e tests to check whether the modified changes are affecting any other functionalities.
- Tried to send an AWS health event from different service other than EC2 from SQS service.
- Verified if the sent message has been deleted and a warning message is returned.
- Tried to send an AWS Health Event with EC2 service and verified if the output for that Event is as expected.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.