Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ci.yml #508

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Update ci.yml #508

merged 1 commit into from
Oct 14, 2021

Conversation

bwagner5
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:

  • License test gets throttled by github, so inject readonly GITHUB TOKEN on PRs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brycahta brycahta self-requested a review October 14, 2021 16:17
snay2
snay2 approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@snay2 snay2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 minutes to run the license check is a fabulous improvement!

@brycahta
Copy link
Contributor

8 minutes to run the license check is a fabulous improvement!

Down from 1h 8m 59s!

brycahta
brycahta approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@brycahta brycahta merged commit f6ef768 into main Oct 14, 2021
@brycahta brycahta deleted the license-test-fix branch October 14, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brycahta brycahta brycahta approved these changes

@snay2 snay2 snay2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwagner5 @brycahta @snay2