Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Faster #486

Merged
merged 3 commits into from
Aug 24, 2021
Merged

Release Faster #486

merged 3 commits into from
Aug 24, 2021

Conversation

bwagner5
Copy link
Contributor

Don't run builds and tests on a release since they've been run at least twice before.

@bwagner5 bwagner5 requested a review from brycahta August 24, 2021 15:24
brycahta
brycahta suggested changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update needs: block to remove build jobs. Ex:

  releaseLinux:
    name: Release Linux
    runs-on: ubuntu-20.04
    needs: [buildWindows, buildWindowsDocker, buildLinux, buildLinuxDocker, fastTests]

brycahta
brycahta previously approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fast to me 🚀

@brycahta
Copy link
Contributor

But this should be running the tests?

brycahta
brycahta approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good pending tests 👍

@bwagner5 bwagner5 merged commit aba9b8d into aws:main Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brycahta brycahta brycahta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwagner5 @brycahta