Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix draft-release-notes issue w/ single quotes #449

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Jun 4, 2021

Issue #, if available:
N/A

Description of changes:

  • Removed xargs pipe since it's unnecessary and causes issues when a commit message has an apostrophe (single quote).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwagner5 bwagner5 requested a review from brycahta June 4, 2021 18:19
brycahta added a commit to aws/amazon-ec2-metadata-mock that referenced this pull request Jun 4, 2021
Same as aws/aws-node-termination-handler#449

Removed xargs pipe since it's unnecessary and causes issues when a commit message has an apostrophe (single quote)
brycahta added a commit to aws/amazon-ec2-instance-selector that referenced this pull request Jun 4, 2021
Same as aws/aws-node-termination-handler#449

Removed xargs pipe since it's unnecessary and causes issues when a commit message has an apostrophe (single quote)
Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for the fix

@brycahta brycahta merged commit 8d586c2 into aws:main Jun 4, 2021
bwagner5 pushed a commit to aws/amazon-ec2-metadata-mock that referenced this pull request Jun 4, 2021
Same as aws/aws-node-termination-handler#449

Removed xargs pipe since it's unnecessary and causes issues when a commit message has an apostrophe (single quote)
bwagner5 pushed a commit to aws/amazon-ec2-instance-selector that referenced this pull request Jun 4, 2021
Same as aws/aws-node-termination-handler#449

Removed xargs pipe since it's unnecessary and causes issues when a commit message has an apostrophe (single quote)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants