Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added windows 2022 support #1057

Merged
merged 1 commit into from
Sep 3, 2024
Merged

added windows 2022 support #1057

merged 1 commit into from
Sep 3, 2024

Conversation

Lu-David
Copy link
Contributor

@Lu-David Lu-David commented Aug 22, 2024

Issue #826

Updated scripts to build, test, and push docker images supporting both Windows 2019 and Windows 2022.

Manual testing:

  1. Spun up EC2 Instance running Windows 2022 Base image and Windows 2019 Base Image. Verified docker pull and run NTH work properly
  2. Set up EKS cluster. Verified helm release would run on all linux, windows2019, and windows2022 nodes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Lu-David Lu-David marked this pull request as ready for review August 22, 2024 23:32
@Lu-David Lu-David requested a review from a team as a code owner August 22, 2024 23:32
Copy link
Contributor

@LikithaVemulapalli LikithaVemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some inline comments, good work on your first PR :)

.github/workflows/build-and-test.yaml Outdated Show resolved Hide resolved
.github/workflows/build-and-test.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
scripts/ecr-public-login Outdated Show resolved Hide resolved
scripts/push-docker-images Show resolved Hide resolved
@Lu-David
Copy link
Contributor Author

Screenshot 2024-08-27 at 4 45 22 PM
Screenshot 2024-08-27 at 4 45 08 PM

Copy link
Contributor

@LikithaVemulapalli LikithaVemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Lu-David Lu-David merged commit 79488f8 into aws:main Sep 3, 2024
16 checks passed
Lu-David added a commit that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants