Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency list #138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update dependency list #138

wants to merge 1 commit into from

Conversation

dwhjames
Copy link

@dwhjames dwhjames commented Jun 1, 2024

Release v0.4.1 at commit 550f731 (PR #121) pinned the version of awslabs/[email protected].

This issue was reported in this project in Issue #122 and upstream in Issue awslabs/aws-c-io#576.

Fixed versions

Issue awslabs/aws-c-io#576 was fixed in awslabs/aws-c-io#613. The fix commit 749c87e was first released in v0.14.0.

There were a further 3 cascading changes.

  1. PR awslabs/aws-c-common#1079 where fix commit 8eaa098 was first released in v0.9.12.
  2. PR awslabs/aws-c-http#457 where fix commit 6a1c157 was first released in v0.8.0.
  3. PR awslabs/aws-c-auth#220 where fix commit 6ba7a0f was first released in v0.7.10

Remaining changes

awslabs/aws-c-sdkutils was at v0.1.2. The latest compatible patch release is v0.1.15. The next patch release v0.1.16 breaks due to paired changes in awslabs/aws-c-sdkutils#39 and awslabs/aws-c-common#1105.

awslabs/aws-c-compression was at v0.2.14. The latest patch release is v0.2.18.

awslabs/aws-c-cal was at v0.5.18. Linking compatibility now requires at least v0.6.0 due dependencies on the changes in awslabs/aws-c-cal#152. The latest patch release is v0.6.15.

aws/s2n-tls was at v1.3.46. At v1.4.0 it changed its version pinning for aws/aws-lc to v1.17.4.

The latest release of json-c is json-c-0.17-20230812.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Release [v0.4.1](https://github.com/aws/aws-nitro-enclaves-sdk-c/releases/tag/v0.4.1)
at commit [550f731](aws@550f731) (PR [aws#121](aws#121))
pinned the version of [awslabs/[email protected]](https://github.com/awslabs/aws-c-io/releases/tag/v0.11.0).

This issue was reported in this project in Issue [aws#122](aws#122) and upstream in Issue [awslabs/aws-c-io#576](awslabs/aws-c-io#576).

**Fixed versions**

Issue [awslabs/aws-c-io#576](awslabs/aws-c-io#576) was fixed in [awslabs/aws-c-io#613](awslabs/aws-c-io#613). The fix commit [749c87e](awslabs/aws-c-io@749c87e) was first released in [v0.14.0](https://github.com/awslabs/aws-c-io/releases/tag/v0.14.0).

There were a further 3 cascading changes.

1. PR [awslabs/aws-c-common#1079](awslabs/aws-c-common#1079) where fix commit [8eaa098](awslabs/aws-c-common@8eaa098) was first released in [v0.9.12](https://github.com/awslabs/aws-c-common/releases/tag/v0.9.12).
2. PR [awslabs/aws-c-http#457](awslabs/aws-c-http#457) where fix commit [6a1c157](awslabs/aws-c-http@6a1c157) was first released in [v0.8.0](https://github.com/awslabs/aws-c-http/releases/tag/v0.8.0).
3. PR [awslabs/aws-c-auth#220](awslabs/aws-c-auth#220) where fix commit [6ba7a0f](awslabs/aws-c-auth@6ba7a0f) was first released in [v0.7.10](https://github.com/awslabs/aws-c-auth/releases/tag/v0.7.10)

---

**Remaining changes**

[awslabs/aws-c-sdkutils](https://github.com/awslabs/aws-c-sdkutils) was at [v0.1.2](https://github.com/awslabs/aws-c-sdkutils/releases/tag/v0.1.2). The latest compatible patch release is [v0.1.15](https://github.com/awslabs/aws-c-sdkutils/releases/tag/v0.1.15).
The next patch release [v0.1.16](https://github.com/awslabs/aws-c-sdkutils/releases/tag/v0.1.16) breaks due to paired changes in [awslabs/aws-c-sdkutils#39](awslabs/aws-c-sdkutils#39) and [awslabs/aws-c-common#1105](awslabs/aws-c-common#1105).

[awslabs/aws-c-compression](https://github.com/awslabs/aws-c-compression) was at [v0.2.14](https://github.com/awslabs/aws-c-compression/releases/tag/v0.2.14). The latest patch release is [v0.2.18](https://github.com/awslabs/aws-c-compression/releases/tag/v0.2.18).

[awslabs/aws-c-cal](https://github.com/awslabs/aws-c-cal) was at [v0.5.18](https://github.com/awslabs/aws-c-cal/releases/tag/v0.5.18). Linking compatibility now requires at least [v0.6.0](https://github.com/awslabs/aws-c-cal/releases/tag/v0.6.0) due dependencies on the changes in [awslabs/aws-c-cal#152](awslabs/aws-c-cal#152). The latest patch release is [v0.6.15](https://github.com/awslabs/aws-c-cal/releases/tag/v0.6.15).

[aws/s2n-tls](https://github.com/aws/s2n-tls) was at [v1.3.46](https://github.com/aws/s2n-tls/releases/tag/v1.3.46). At [v1.4.0](https://github.com/aws/s2n-tls/releases/tag/v1.4.0) it changed its version pinning for [aws/aws-lc](https://github.com/aws/aws-lc) to [v1.17.4](https://github.com/aws/aws-lc/releases/tag/v1.17.4).

The latest release of [json-c](https://github.com/json-c/json-c) is [json-c-0.17-20230812](https://github.com/json-c/json-c/releases/tag/json-c-0.17-20230812).
@dwhjames
Copy link
Author

dwhjames commented Jun 1, 2024

Confirming that I have tested with

@jplock
Copy link

jplock commented Nov 19, 2024

Should this be updated?

@dwhjames
Copy link
Author

@jplock was this a question to me, or to the project maintainers?

If to me, are you asking if this PR should be refreshed with respect to the ~6 months of staleness?

The versions chosen were somewhat conservative at the time. The 4 versions chosen in the ‘Fixed versions’ section were the version numbers where the fix was first available. The versions chosen in the ‘Remaining changes’ section were chosen mostly to follow patch-only version number increases for the cases that are major=0 (and there was still a case of encountering breaking changes).

@jplock
Copy link

jplock commented Nov 20, 2024

Both I guess, would be nice to get this using more recent versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants