Fix Unused statements for fiat #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have `OPENSSL_UNUSED` statements for our fiat header files in order to prevent errors for functions that we don't use. There was a mistake that used the 64-bit function definitions for the 32-bit header file. On some platforms this would cause a compilation error.
samuel40791765
approved these changes
Jun 8, 2022
|
We see a small regression in |
torben-hansen
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have
OPENSSL_UNUSEDstatements for our fiat header files in orderto prevent errors for functions that we don't use. There was a mistake
that used the 64-bit function definitions for the 32-bit header file. On
some platforms this would cause a compilation error.
Issues:
Potential fix for #487
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.