CI fixes #36
Closed
CI fixes #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryce-shang
reviewed
Sep 4, 2020
| @@ -4,3 +4,4 @@ | |||
| 0004-disable-urandom-test-docker.patch | |||
| 0005-fix-ssl-test-runner-output.patch | |||
| 0006-fix-gcc4-compile-errors.patch | |||
| 0007-fix-abi-test-compilation.patch | |||
There was a problem hiding this comment.
main has 007 patch. Need to change this to 008 or 009.
Comment on lines
+32
to
+37
| WriteFile(stderr_handle, buf, strlen(buf), &unused, nullptr); | ||
| } | ||
| #else | ||
| - write(STDERR_FILENO, buf, strlen(buf)); | ||
| + OPENSSL_UNUSED ssize_t unused_ret = | ||
| + write(STDERR_FILENO, buf, strlen(buf)); |
There was a problem hiding this comment.
Is this to fix gcc4 related compile warning?
Comment on lines
-2
to
3
| # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| #!/bin/bash | ||
|
|
||
| # This test is aimed to run with GCC 6 and above on x86-64 architectures. |
There was a problem hiding this comment.
The copyright header is needed based on open source policy.
|
Closing in favor of #40 |
dkostic
pushed a commit
to dkostic/aws-lc
that referenced
this pull request
Sep 1, 2022
Basic point operations for the Weierstrass curves s2n-bignum original commit: awslabs/s2n-bignum@44003b0
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Mar 31, 2023
Basic point operations for the Weierstrass curves s2n-bignum original commit: awslabs/s2n-bignum@44003b0
aqjune
pushed a commit
to aqjune-aws/aws-lc-public
that referenced
this pull request
Jul 25, 2023
Basic point operations for the Weierstrass curves s2n-bignum original commit: awslabs/s2n-bignum@44003b0
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Nov 15, 2023
Basic point operations for the Weierstrass curves s2n-bignum original commit: awslabs/s2n-bignum@44003b0
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 18, 2024
Basic point operations for the Weierstrass curves s2n-bignum original commit: awslabs/s2n-bignum@44003b0 s2n-bignum original commit: awslabs/s2n-bignum@2af9c6a
dkostic
pushed a commit
to dkostic/aws-lc
that referenced
this pull request
Dec 5, 2024
Basic point operations for the Weierstrass curves
dkostic
pushed a commit
to dkostic/aws-lc
that referenced
this pull request
Dec 10, 2024
Basic point operations for the Weierstrass curves s2n-bignum original commit: awslabs/s2n-bignum@44003b0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
CryptoAlg-345
Description of changes:
Re-enables unit tests that were failing in CodeBuild.
Testing:
CI tests are all calling
run_posix_tests.shand passing.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.