Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CRL tool to CLI #1976

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Added CRL tool to CLI #1976

merged 3 commits into from
Nov 15, 2024

Conversation

smittals2
Copy link
Contributor

Issues:

CryptoAlg-2679

Description of changes:

Added the crl tool to the openssl cli with -hash, -fingerprint, -help, -in, -noout

Testing

Option and OpenSSL comparison tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@smittals2 smittals2 requested a review from a team as a code owner November 8, 2024 06:19
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 60.52632% with 45 lines in your changes missing coverage. Please review.

Project coverage is 78.91%. Comparing base (2d07d39) to head (b9753d4).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
tool-openssl/crl_test.cc 56.16% 27 Missing and 5 partials ⚠️
tool-openssl/crl.cc 68.29% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1976       +/-   ##
===========================================
  Coverage        ?   78.91%               
===========================================
  Files           0      595      +595     
  Lines           0   102079   +102079     
  Branches        0    14472    +14472     
===========================================
+ Hits            0    80557    +80557     
- Misses          0    20871    +20871     
- Partials        0      651      +651     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tool-openssl/crl.cc Outdated Show resolved Hide resolved
tool-openssl/crl.cc Outdated Show resolved Hide resolved
tool-openssl/crl_test.cc Outdated Show resolved Hide resolved
tool-openssl/crl_test.cc Outdated Show resolved Hide resolved
tool-openssl/crl.cc Outdated Show resolved Hide resolved
tool-openssl/crl.cc Outdated Show resolved Hide resolved
tool-openssl/crl.cc Outdated Show resolved Hide resolved
tool-openssl/crl_test.cc Outdated Show resolved Hide resolved
@smittals2 smittals2 merged commit cc0ce55 into aws:main Nov 15, 2024
116 of 117 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants