Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand support for EVP_PKEY_HMAC #1933

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Oct 18, 2024

Issues:

Addresses CryptoAlg-2695

Description of changes:

  • Expands support for EVP_PKEY_HMAC
    • Support for "keygen" operations
    • Support for EVP_PKEY_CTX_ctrl_str.
    • Support for EVP_PKEY_CTRL_SET_MAC_KEY operation w/ EVP_PKEY_CTX_ctrl

Testing:

  • New tests added.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 13 lines in your changes missing coverage. Please review.

Project coverage is 78.68%. Comparing base (d93711c) to head (470994e).

Files with missing lines Patch % Lines
crypto/fipsmodule/evp/p_hmac.c 79.36% 13 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1933   +/-   ##
=======================================
  Coverage   78.67%   78.68%           
=======================================
  Files         585      585           
  Lines      100849   100914   +65     
  Branches    14299    14313   +14     
=======================================
+ Hits        79345    79404   +59     
- Misses      20870    20875    +5     
- Partials      634      635    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth force-pushed the ruby-hmac-integ branch 3 times, most recently from a1b36dd to c8d764b Compare October 23, 2024 15:29
@justsmth justsmth marked this pull request as ready for review October 23, 2024 15:39
@justsmth justsmth requested a review from a team as a code owner October 23, 2024 15:39
@justsmth justsmth changed the title [DRAFT] Expand support for EVP_PKEY_HMAC Expand support for EVP_PKEY_HMAC Oct 23, 2024
crypto/fipsmodule/evp/evp_ctx_test.cc Show resolved Hide resolved
crypto/fipsmodule/evp/p_hmac.c Outdated Show resolved Hide resolved
crypto/fipsmodule/evp/p_hmac.c Outdated Show resolved Hide resolved
crypto/fipsmodule/evp/p_hmac.c Show resolved Hide resolved
crypto/fipsmodule/evp/p_hmac.c Outdated Show resolved Hide resolved
crypto/fipsmodule/evp/p_hmac.c Show resolved Hide resolved
crypto/fipsmodule/evp/evp_ctx_test.cc Outdated Show resolved Hide resolved
@justsmth justsmth merged commit 8d9809e into aws:main Oct 28, 2024
114 of 115 checks passed
skmcgrail added a commit that referenced this pull request Nov 7, 2024
## What's Changed
* 800-131Ar1: length of the key-derivation key shall be at least 112
bits. by @skmcgrail in #1924
* Marshalling/Unmarshalling DH public keys by @justsmth in
#1916
* Also prune SSM documents from ec2-test-framework by @samuel40791765 in
#1925
* Use illegal_parameter instead of decode_error for invalid key shares
by @justsmth in #1923
* Add null check in dh testing by @torben-hansen in
#1937
* DH paramgen callback by @justsmth in
#1928
* Upstream merge 2024 10 17 by @torben-hansen in
#1934
* Remove old Intel CPU types by @justsmth in
#1942
* Remove retries on PCT failure in EC and RSA key generation. by @nebeid
in #1938
* Add p4p, bump up time by @justsmth in
#1943
* PQ README by @jakemas in #1932
* bump mysql CI to 9.1.0 by @justsmth in
#1939
* HKDF, HKDF_expand, and PBKDF Truncated SHA2-512 by @skmcgrail in
#1946
* Missing functionality + Adding Nmap to our CI by @smittals2 in
#1915
* Fix FIPS.md typo by @justsmth in
#1950
* Support encode or decode ∞ like OpenSSL by @samuel40791765 in
#1930
* Expand support for EVP_PKEY_HMAC by @justsmth in
#1933
* Add PKCS7-internal BIO_f_cipher by @WillChilds-Klein in
#1836
* Add PKCS7-internal BIO_f_md by @WillChilds-Klein in
#1886
* Ruby Support - DSA custom md by @justsmth in
#1953
* Add support for POINT_CONVERSION_HYBRID by @samuel40791765 in
#1936
* Fixes for Coverity Alerts by @smittals2 in
#1960
* Also test w/ gcc 4.8 by @justsmth in
#1962
* Actually add support for SSL_get_server/peer_tmp_key by
@samuel40791765 in #1945
* Coverity Fix Null Check by @smittals2 in
#1965
* ML-KEM keygen Pairwise Consistency Test by @dkostic in
#1964
* EDDSA PCT by @torben-hansen in #1968
* Expose AES_cfb1_encrypt and AES_cfb8_encrypt by @skmcgrail in
#1967

**Full Changelog**:
v1.37.0...v1.38.0

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants