Improve gcc-4.8 support/testing #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
force-pushed
the
improve-legacy-testing
branch
from
df3fde0
to
4a7039f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1665 +/- ##
=======================================
Coverage 78.19% 78.20%
=======================================
Files 571 571
Lines 95458 95459 +1
Branches 13705 13704 -1
=======================================
+ Hits 74642 74651 +9
+ Misses 20204 20199 -5
+ Partials 612 609 -3 ☔ View full report in Codecov by Sentry. |
justsmth
force-pushed
the
improve-legacy-testing
branch
2 times, most recently
from
3f3042c
to
9d4d510
Compare
justsmth
changed the title
justsmth
force-pushed
the
improve-legacy-testing
branch
8 times, most recently
from
4c3b275
to
34ae194
Compare
justsmth
changed the title
justsmth
force-pushed
the
improve-legacy-testing
branch
from
34ae194
to
47e9bf2
Compare
justsmth
force-pushed
the
improve-legacy-testing
branch
2 times, most recently
from
e805c52
to
3c3f957
Compare
nebeid
reviewed
Jul 3, 2024
justsmth
force-pushed
the
improve-legacy-testing
branch
from
3c3f957
to
6edceb9
Compare
nebeid
reviewed
Jul 8, 2024
nebeid
approved these changes
Jul 8, 2024
dkostic
approved these changes
Jul 8, 2024
justsmth
added a commit
that referenced
this pull request
Jul 12, 2024
### Issues: * Addresses: CryptoAlg-2220 ### Previous Work: This change re-introduces changes from the following PRs: * #1628 Due to build failures with certain environments using gcc-4.8, the above was reverted: * #1656 The build failures were addressed in the following PR: * #1665 ### Description of changes: Upstream commits: * google/boringssl@9fc1c33 * google/boringssl@51ed32f By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. --------- Co-authored-by: Bob Beck <[email protected]>
lilpoozie2005
approved these changes
Sep 11, 2024
lilpoozie2005
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Call-out
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.