Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI update for ubuntu 24.04 #1599

Merged
merged 3 commits into from
May 24, 2024
Merged

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented May 16, 2024

Description of changes:

  • Fixes previous CI failures due to gcc-13 not being present.
  • Updates CI compilation "sanity test" to included compilers on Ubuntu 24.04
  • Cherry-picked recent commit from BoringSSL that fixes gcc-14 build error.
  • Add CI cross-compilation test for loongaarch64.

Callout

  • The gcc-14 FIPS build failure is related to the "delocator" and is still being researched.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth force-pushed the ci-ubuntu-compiler-update branch 3 times, most recently from c65526c to e775a83 Compare May 16, 2024 18:03
justsmth and others added 2 commits May 16, 2024 14:19
GCC does not support C11 _Generic in C++ mode.

Change-Id: I974a0b04bbe4900419736044d0d8050f2b856d56
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/68507
Auto-Submit: David Benjamin <[email protected]>
Commit-Queue: David Benjamin <[email protected]>
Reviewed-by: Adam Langley <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.91%. Comparing base (6ced83c) to head (9995773).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1599   +/-   ##
=======================================
  Coverage   77.90%   77.91%           
=======================================
  Files         561      561           
  Lines       94632    94632           
  Branches    13604    13603    -1     
=======================================
+ Hits        73725    73731    +6     
+ Misses      20316    20308    -8     
- Partials      591      593    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth marked this pull request as ready for review May 16, 2024 20:36
@justsmth justsmth requested a review from a team as a code owner May 16, 2024 20:36
@justsmth
Copy link
Contributor Author

The (static) FIPS build with gcc-14 is broken, but this PR fixes the normal build w/ gcc-14 and provide visibility into more clang compiler version.

@justsmth justsmth requested a review from skmcgrail May 16, 2024 20:40
@justsmth justsmth changed the title [DRAFT] CI update for ubuntu 24.04 CI update for ubuntu 24.04 May 16, 2024
@justsmth justsmth requested a review from smittals2 May 17, 2024 12:44
@justsmth justsmth enabled auto-merge (squash) May 23, 2024 20:47
@justsmth justsmth merged commit dde8d51 into aws:main May 24, 2024
90 of 92 checks passed
@justsmth justsmth deleted the ci-ubuntu-compiler-update branch May 24, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants