Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NTP integration test in the case of multiple occurrences of the package #1588

Closed
wants to merge 1 commit into from

Conversation

nebeid
Copy link
Contributor

@nebeid nebeid commented May 10, 2024

Fix the NTP integration test, a continuation of the fix in #1548.

When there were multiple .tar.gz packages, the test was trying wget with

wget -q https://downloads.nwtime.org/ntp//ntp-4.2.8p17.tar.gz ntp-4.2.8p18-RC1.tar.gz

and was failing.

@nebeid nebeid requested a review from a team as a code owner May 10, 2024 22:36
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.90%. Comparing base (e82f824) to head (065579c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1588      +/-   ##
==========================================
- Coverage   77.91%   77.90%   -0.01%     
==========================================
  Files         560      560              
  Lines       94613    94613              
  Branches    13618    13618              
==========================================
- Hits        73720    73711       -9     
- Misses      20299    20308       +9     
  Partials      594      594              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nebeid
Copy link
Contributor Author

nebeid commented May 13, 2024

Superseded by #1589

@nebeid nebeid closed this May 13, 2024
@nebeid nebeid deleted the fix-ntp-test-again branch July 24, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants