Refactor ED25519_sign into hw and nohw backend #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkostic
previously approved these changes
Nov 3, 2023
nebeid
reviewed
Nov 3, 2023
torben-hansen
force-pushed
the
refactor_ed25519_sign_prep_for_s2n_bignum
branch
from
3d4e45c to
87442d9
Compare
dkostic
approved these changes
Nov 13, 2023
skmcgrail
approved these changes
Nov 13, 2023
This was referenced Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Refactors
ED25519_signinto a no-hardware and a hardware path. Existing backend is the former. Preparation for s2n-bignum Ee25519.s2n-bignum is lacking SHA512. So unfortunately, I can't punt this computation to s2n-bignum.
PR chain:
ED25519_keypairRefactor ED25519_keypair into hw and nohw backend #1271ED25519_signED25519_verifyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.