Add BNAssertTest #1267
Merged
Add BNAssertTest #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
reviewed
Oct 26, 2023
skmcgrail
previously approved these changes
Oct 26, 2023
torben-hansen
previously approved these changes
Oct 26, 2023
justsmth
dismissed stale reviews from torben-hansen and skmcgrail
via
67c371f
torben-hansen
previously approved these changes
Oct 26, 2023
skmcgrail
previously approved these changes
Oct 26, 2023
skmcgrail
dismissed stale reviews from torben-hansen and themself
via
5a90560
justsmth
force-pushed
the
bn-assert-tests
branch
from
5a90560 to
7b6731e
Compare
samuel40791765
previously approved these changes
Nov 2, 2023
justsmth
force-pushed
the
bn-assert-tests
branch
from
7b6731e to
466f8fe
Compare
nebeid
reviewed
Nov 3, 2023
nebeid
approved these changes
Nov 3, 2023
justsmth
force-pushed
the
bn-assert-tests
branch
from
466f8fe to
3b1c415
Compare
justsmth
force-pushed
the
bn-assert-tests
branch
from
3b1c415 to
4ae4479
Compare
skmcgrail
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
N/A
Description of changes:
bn_assert_fits_in_bytesCall-outs:
bn_assert_fits_in_bytessymbol for testing, but its definition is only visible internally.Testing:
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.