Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ed25519KeyPair::generate #576

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

skmcgrail
Copy link
Member

Issues:

Resolves #572

Adds support for Ed25519KeyPair::generate(). I've opted to not allow passing a reference to an rng like that presented in the issue, as the parameter would be ignored like it is in the other generation functions available today.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@skmcgrail skmcgrail requested a review from a team as a code owner November 5, 2024 01:25
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.62%. Comparing base (c358484) to head (367de83).
Report is 104 commits behind head on main.

Files with missing lines Patch % Lines
aws-lc-rs/src/ed25519.rs 92.59% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
- Coverage   95.80%   92.62%   -3.18%     
==========================================
  Files          61       67       +6     
  Lines        8143     9393    +1250     
  Branches        0     9393    +9393     
==========================================
+ Hits         7801     8700     +899     
- Misses        342      421      +79     
- Partials        0      272     +272     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skmcgrail skmcgrail merged commit afe3d3b into aws:main Nov 14, 2024
240 of 246 checks passed
@skmcgrail skmcgrail deleted the issue572 branch November 14, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ed25519KeyPair::generate(&rng) function
4 participants