Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup build scripts #561

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Cleanup build scripts #561

merged 4 commits into from
Oct 16, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Oct 8, 2024

Description of changes:

  • Realign logic between the aws-lc-sys and aws-lc-fip-sys build scripts.
  • Log the version of Clang being used for bindgen.
  • Utilize macro to ensure consistent conditional compilation condition.

Callout

  • Bindgen 0.69.5 should now support Clang 19.1

Testing:

Added test to verify that builds succeed w/ Cland 19.1 and bindgen.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner October 8, 2024 18:01
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (c358484) to head (099f3ac).
Report is 99 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
- Coverage   95.80%   92.62%   -3.18%     
==========================================
  Files          61       67       +6     
  Lines        8143     9366    +1223     
  Branches        0     9366    +9366     
==========================================
+ Hits         7801     8675     +874     
- Misses        342      420      +78     
- Partials        0      271     +271     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth merged commit 5f19cae into aws:main Oct 16, 2024
240 of 245 checks passed
@justsmth justsmth deleted the cleanup-cfg branch October 16, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants