Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FreeBSD build not targetting release 13.4 #550

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

yonas
Copy link
Contributor

@yonas yonas commented Oct 2, 2024

Description of changes:

Fix typo in the cross build for FreeBSD. Only the latest release was being targeted.

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@yonas yonas requested a review from a team as a code owner October 2, 2024 20:23
Copy link
Contributor

@justsmth justsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh... Good catch!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (c358484) to head (3d68a93).
Report is 90 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
- Coverage   95.80%   92.52%   -3.28%     
==========================================
  Files          61       67       +6     
  Lines        8143     9277    +1134     
  Branches        0     9277    +9277     
==========================================
+ Hits         7801     8584     +783     
- Misses        342      422      +80     
- Partials        0      271     +271     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skmcgrail skmcgrail merged commit 3b899c2 into aws:main Oct 3, 2024
224 of 234 checks passed
@yonas yonas deleted the freebsd-matrix-target branch October 3, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants