Support compressed octets format in agreement::agree_ephemeral() #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansonchar
changed the title
hansonchar
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
+ Coverage 95.65% 95.67% +0.01%
==========================================
Files 57 57
Lines 7759 7818 +59
==========================================
+ Hits 7422 7480 +58
- Misses 337 338 +1 ☔ View full report in Codecov by Sentry. |
hansonchar
force-pushed
the
main
branch
3 times, most recently
from
c62c256
to
50d210a
Compare
hansonchar
force-pushed
the
main
branch
3 times, most recently
from
c182a72
to
46e4b53
Compare
hansonchar
force-pushed
the
main
branch
2 times, most recently
from
abcdc23
to
3116d68
Compare
hansonchar
force-pushed
the
main
branch
2 times, most recently
from
fc633c6
to
88747f5
Compare
hansonchar
force-pushed
the
main
branch
3 times, most recently
from
f34fd6a
to
dff147b
Compare
hansonchar
force-pushed
the
main
branch
2 times, most recently
from
61de423
to
da614a0
Compare
+ Add EphemeralPrivateKey.compute_public_key_compressed() + Fix test cases for public keys in compressed format
|
I've stashed this PR contents at https://github.com/aws/aws-lc-rs/tree/hansonchar/main until we have time to review this work as part of the broader service teams' requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #1255
Description of changes:
agreement::agree_ephemeral()supports the peer public key in uncompressed octets format, but rejects if the peer public key is in compressed octets format.compute_public_key_compressedtoEphemeralPrivateKeyso that users can retrieve the EC public key in compressed format when applicable.Call-outs:
I've changed the test cases that used to disallow peer public key in compressed format to now allow them.
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.