Removing env writer #396
Merged
Removing env writer #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
smirnoal
force-pushed
the
dev-feature-x
branch
from
4285e0a to
cd0192a
Compare
|
the smoke tests are failing because of a docker buildx installation problem. I will fix it in my next PR |
bmoffatt
approved these changes
Jan 14, 2023
anton-stepanof
approved these changes
Jan 16, 2023
|
created a ticket for OpenTelemtery to use system properties instead of env vars: open-telemetry/opentelemetry-java-instrumentation#7579 |
smirnoal
force-pushed
the
dev-feature-x
branch
from
4285e0a to
a68d9e0
Compare
github-actions
bot
force-pushed
the
dev-feature-x
branch
from
a68d9e0 to
4285e0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removing class for modifying environment variables from Lambda runtime. More details here: #261 (comment)