-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat<events.cognito>: add support for custom email sender #419
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #419 +/- ##
=======================================
Coverage 71.66% 71.66%
=======================================
Files 19 19
Lines 1041 1041
=======================================
Hits 746 746
Misses 228 228
Partials 67 67 Continue to review full report at Codecov.
|
LGTM, do you have an AWS docs link for this feature that I can reference? |
Can we cover custom SMS sender as well? |
Sure, I will add the same for SMS, I have few time available atm, but asap. |
Hey, do you have any updates on this? @BorisLeMeec, do you need any help? |
type CognitoEventUserPoolsCustomEmailSender struct { | ||
CognitoEventUserPoolsHeader | ||
Request CognitoEventUserPoolsCustomEmailSenderRequest `json:"request"` | ||
Response CognitoEventUserPoolsCustomEmailSenderResponse `json:"response"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs don't mention a returned response, I think the sender integration isn't quite the same as the Custom Message integration
Email Sender: https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-lambda-custom-email-sender.html
The custom code of your function must then process and deliver the message.
Compare with Custom Message Trigger: https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-lambda-custom-message.html#cognito-user-pools-lambda-trigger-syntax-custom-message
In the response, specify the custom text to use in messages to your users.
Is this change still happening? Running into the need for the Email/SMS event models in a project I'm working on |
Hey, @BorisLeMeec, @bmoffatt is there an update regarding the support for the custom email sender event? Are there any blockers for merging this? |
Bump, any updates on this one? Anyone uses a workaround? |
Issue #, if available:
#370
Description of changes:
added new event struct for support of customEmailSender messages.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.