Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lambda: check if error type is InvokeResponse_Error #312

Merged
merged 2 commits into from
Sep 22, 2020
Merged

lambda: check if error type is InvokeResponse_Error #312

merged 2 commits into from
Sep 22, 2020

Commits on Aug 11, 2020

  1. lambda: check if error type is InvokeResponse_Error 

    Currently, we cannot set the errorType field without creating a custom
named error type. This causes a proliferation of dummy named error types
whose only purpose is to set a text field, and limits the errorType
field to what can be expressed as an identifier.

This change checks that the panicked or returned error is if type
InvokeResponse_Error, and if so, uses it directly in the invoker's
response. InvokeResponse_Error is now updated to implement error.

Note: This is fully backwards compatible, since InvokeResponse_Error
previously did not implement the error interface.

Fixes aws#308.
    @smasher164
    smasher164 committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    488ab7a View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. Merge branch 'master' into issue-308

    @bmoffatt
    bmoffatt authored Sep 22, 2020
    Configuration menu
    Copy the full SHA
    c7abb62 View commit details
    Browse the repository at this point in the history