Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed loses precision for large values #227

Merged
merged 2 commits into from
Oct 14, 2019
Merged

Conversation

joeke80215
Copy link
Contributor

Issue #, if available:
#186
Description of changes:
loses precision for large values

Copy link
Contributor

@diegobernardes diegobernardes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the code change proposal.

@joeke80215
Copy link
Contributor Author

ok, thanks your suggest

@codecov-io
Copy link

codecov-io commented Oct 13, 2019

Codecov Report

Merging #227 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   74.44%   74.59%   +0.15%     
==========================================
  Files          20       20              
  Lines         677      681       +4     
==========================================
+ Hits          504      508       +4     
  Misses        128      128              
  Partials       45       45
Impacted Files Coverage Δ
events/attributevalue.go 82.75% <100%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62a881e...d627d04. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants