Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

205 fix mini panic #226

Merged
merged 4 commits into from
Aug 29, 2019
Merged

205 fix mini panic #226

merged 4 commits into from
Aug 29, 2019

Conversation

apzuk3
Copy link
Contributor

@apzuk3 apzuk3 commented Aug 24, 2019

Issue #205

Description of changes:

Came across this bug the other day and spent quite a long time to figure out what's going on because it is really confusing.

So this is a fix proposal to check if the av.dataType is not DataTypeString return the string representation of the struct, panic otherwise

@codecov-io
Copy link

codecov-io commented Aug 24, 2019

Codecov Report

Merging #226 into master will decrease coverage by 0.11%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
- Coverage   74.55%   74.44%   -0.12%     
==========================================
  Files          20       20              
  Lines         676      677       +1     
==========================================
  Hits          504      504              
- Misses        127      128       +1     
  Partials       45       45
Impacted Files Coverage Δ
events/attributevalue.go 82.51% <66.66%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec56cb7...395e69e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants