Add Kinesis Stream Metadata to firehose event #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
======================================
Coverage 77.2% 77.2%
======================================
Files 18 18
Lines 636 636
======================================
Hits 491 491
Misses 104 104
Partials 41 41Continue to review full report at Codecov.
|
bhavikkumar
changed the title
bmoffatt
reviewed
May 10, 2019
| ShardID string `json:"shardId"` | ||
| PartitionKey string `json:"partitionKey"` | ||
| SequenceNumber string `json:"sequenceNumber"` | ||
| ApproximateArrivalTimestamp MilliSecondsEpochTime `json:"approximateArrivalTimestamp"` |
There was a problem hiding this comment.
The CI failed (https://travis-ci.org/aws/aws-lambda-go/builds/530382884). Need to check if the type needs to be string, or if the test data is wrong.
...
--- FAIL: TestSampleTransformation (0.00s)
firehose_test.go:50: could not unmarshal event. details: json: cannot unmarshal string into Go struct field KinesisFirehoseRecordMetadata.approximateArrivalTimestamp of type int64
...
There was a problem hiding this comment.
found a reference internally and a sample event in the console - I will update the test data and merge
updated type to match sample in Lambda console
bmoffatt
approved these changes
May 10, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sourceKinesisStreamArn and KinesisRecordMetadata to event structs .
Attempting to do a put record API call on a Firehose Delivery stream which has a Kinesis Stream as the source will result in the error
This operation is not permitted on KinesisStreamAsSource delivery stream type.. Therefore it is useful to have the sourceKinesisStreamArn so put record API calls can be made by Lambda functions to the source Kinesis Stream.In addition the Kinesis Record Metadata has been added to the event so the same partition key can be used if the data needs to be reingest to the source Kinesis stream.
This is particularly useful when attempting to reingest data due to hitting the 6MB size limit of the response payload.