Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add kinesis analytics event #169

Merged
merged 5 commits into from
Mar 15, 2019

Conversation

vinujohn
Copy link
Contributor

@vinujohn vinujohn commented Feb 18, 2019

Added event and response for Kinesis Analytics output delivery.

Followed structure as defined here: https://docs.aws.amazon.com/kinesisanalytics/latest/dev/how-it-works-output-lambda.html

Naming of event and response was copied from .NET and Java: https://docs.aws.amazon.com/kinesisanalytics/latest/dev/how-it-works-output-lambda-functions.html

Added tests. Refactored existing tests by moving common readJsonFile from dyanamodb_test.go into test package

Reference issue: #99

@codecov-io
Copy link

codecov-io commented Feb 18, 2019

Codecov Report

Merging #169 into master will decrease coverage by 0.07%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   70.33%   70.25%   -0.08%     
==========================================
  Files          18       19       +1     
  Lines         691      696       +5     
==========================================
+ Hits          486      489       +3     
- Misses        165      166       +1     
- Partials       40       41       +1
Impacted Files Coverage Δ
events/test/readjson.go 60% <60%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec1e14...31fc593. Read the comment docs.

inputJson -> inputJSON
@bmoffatt bmoffatt merged commit c941d49 into aws:master Mar 15, 2019
@bmoffatt
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants