Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events for Cognito custom authentication challenge #168

Merged
merged 12 commits into from
Jul 6, 2019
Merged

Add events for Cognito custom authentication challenge #168

merged 12 commits into from
Jul 6, 2019

Conversation

mxpv
Copy link
Contributor

@mxpv mxpv commented Feb 14, 2019

This PR adds events for Cognito's custom authentication - https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-lambda-challenge.html

@codecov-io
Copy link

codecov-io commented Feb 14, 2019

Codecov Report

Merging #168 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #168   +/-   ##
======================================
  Coverage    77.2%   77.2%           
======================================
  Files          18      18           
  Lines         636     636           
======================================
  Hits          491     491           
  Misses        104     104           
  Partials       41      41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84efa13...a283149. Read the comment docs.

events/cognito.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@bmoffatt bmoffatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that CognitoEventUserPoolsVerifyAuthChallengeRequest.ChallengeAnswer is the right type after reading the docs

@hgl
Copy link

hgl commented Jun 23, 2019

Any chance this gets merged anytime soon?

Signed-off-by: Maksym Pavlenko <[email protected]>
@mxpv
Copy link
Contributor Author

mxpv commented Jun 27, 2019

@bmoffatt I'm not quite sure whether map[string]string is the right choice since on my test env I was receiving a string type value, so I decided to go with interface{}

@mxpv
Copy link
Contributor Author

mxpv commented Jul 3, 2019

ping @bmoffatt

@bmoffatt
Copy link
Collaborator

bmoffatt commented Jul 6, 2019

@bmoffatt I'm not quite sure whether map[string]string is the right choice since on my test env I was receiving a string type value, so I decided to go with interface{}

👍

 ChallengeMetaData -> ChallengeMetadata
@bmoffatt bmoffatt merged commit 39a255e into aws:master Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants