Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .samignore for excludes in python_pip_workfow #183

Closed
wants to merge 6 commits into from
Closed

Add .samignore for excludes in python_pip_workfow #183

wants to merge 6 commits into from

Conversation

milesgranger
Copy link

@milesgranger milesgranger commented Jul 20, 2020

Part of #185

Description of changes:
Test the waters for adding something like a .samignore file for reasons described in that issue.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@milesgranger
Copy link
Author

It's failing on another Python 2.7 issue, all others pass. Anyhow, this should get the idea across if it should be taken further.

As a side note, how much longer is Python2.7 going to be supported?

@milesgranger milesgranger marked this pull request as ready for review July 22, 2020 10:26
"""
Use .samignore falling back to default exclude files
"""
sam_ignore = pathlib.Path("./.samignore")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.samignore is a new directory for users to have files that are excluded from the build correct?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually a file, akin to .dockerignore, .gitignore and the like. Which users could place sam specific files/directories to ignore

@mutasemhidmi
Copy link

any update for this?

@milesgranger
Copy link
Author

Have had a workaround for this (just moving everything of importance into a separate directory).
However, it's quite frustrating to have a PR sit open for over a year without any activity. 👎

@alliefitter
Copy link

@sriram-mv Will this be merged? This feature would be a serious quality of life upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants