Fixed broken request path from notebook with base url #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpagtakhan
commented
Feb 3, 2021
| # Given | ||
| upstream_request = HTTPServerRequest( | ||
| method="HEAD", | ||
| uri="base-url/awsproxy/bucket-name-1", |
There was a problem hiding this comment.
I copied an existing test, and changed the upstream request path to include a mock of a Jupyter notebook base url
jaipreet-s
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The derived downstream request path is incorrect for upstream request paths that contain Jupyter notebook base URL. For example, if the the upstream request path is
asdf/awsproxy/..., the derived downstream removes the first 8 characters (the length of the string "/awsproxy") as it assumes it always just starts with "/awsproxy".Solution
Consider that the upstream request path contains a base url. Find (1) the index of "/awsproxy", (2) the length of "/awsproxy". The sum of (1) and (2) is the starting index of the substring to derive the downstream request path.