Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basic discovery sample command line input #448

Merged
merged 1 commit into from
May 2, 2023

Conversation

TwistedTwigleg
Copy link
Contributor

Description of changes:

Fixes the Greengrass sample incorrectly requiring --endpoint to be passed. Also brings back --region instead of --signing_region for backwards compatibility with the Greengrass docs.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TwistedTwigleg
Copy link
Contributor Author

Thanks! Merging into main...

@TwistedTwigleg TwistedTwigleg merged commit 2bb37a3 into main May 2, 2023
@TwistedTwigleg TwistedTwigleg deleted the greengrass_discovery_fix branch May 2, 2023 01:19
@TwistedTwigleg TwistedTwigleg restored the greengrass_discovery_fix branch May 4, 2023 14:43
@TwistedTwigleg TwistedTwigleg deleted the greengrass_discovery_fix branch May 4, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants