Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass connack parameter in device.connect event #99

Closed
wants to merge 1 commit into from

Conversation

hzeitlhofer
Copy link

the base class for awsIot.device is mqtt.Client
the 'connect' event in mqtt.Client supplies a connack parameter, which contains some useful information, but is ignored in the awsIot.device implementation

@liuszeng
Copy link
Contributor

Hi @hzeitlhofer ,

Thank you very much for pointing this out. Our current process for accepting pull requests is to make the relevant changes on our end, let it go through our internal testing process and include them in the next release. We will close this pull request when the release is out that includes this pull request. Please do let us know if you have any further suggestions for improvement.

Thanks,
Liusu

@fengsongAWS
Copy link
Contributor

Problem fixed in latest version of AWS IoT Device SDK in Node.js

Copy link

@rajatprogrammer rajatprogrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we connect with certificates

@gkwicker
Copy link
Contributor

HI @rajatprogrammer, yes you can use certificates to connect. Have a look at the README section on connection types for details. Let us know if you have any other questions, and thanks for using AWS IoT.

@rajatprogrammer
Copy link

@gkwicker bro the mqtt is not connected i follow the same steps but it always try to be connected i test the code in debugger mode .i check the aws variabel in repl mode it show the status trying to connect but it never connect.

@fengsongAWS
Copy link
Contributor

Hi @rajatprogrammer ,
There could be multiple reasons that fail to connect. Can you elaborate your steps?
Here's some common points you can check.
1.Please make sure you activate your certs.
2.Make sure you attach the correct IoT Policy to your iot certs.
3. Make sure you connect to the same region as where you created your thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants