handle SocketOptions not being set #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbSteveK
reviewed
Aug 8, 2023
| @@ -360,6 +360,9 @@ public AwsIotMqttConnectionBuilder withProtocolOperationTimeoutMs(int protocolOp | |||
| * @return {@link AwsIotMqttConnectionBuilder} | |||
| */ | |||
| public AwsIotMqttConnectionBuilder withTimeoutMs(int timeoutMs) { | |||
There was a problem hiding this comment.
Is it possible for this to be called before withSocketOptions() is called? If so, it's possible a customer may set withTimeoutMs() using this which is then overridden by the withSocketOptions(). Maybe we should also add a null check to withSocketOptions() and if it's not null, copy over the timeout from it to the newly set socket options. Or that may be overcomplicating things and we just allow the timeout to be overwritten if the customer somehow decides to use both.
sbSteveK
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
awslabs/aws-crt-java#650
Description of changes:
create new
SocketOptionsif it doesn't exist to avoid null pointer exceptionBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.