-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample and command line refactor #394
Conversation
…tion. Fix PubSub typo
…a connect sample rather than a pubsub one
…e the other samples
…Note in a couple places that Identity and Fleet Provisioning are the same to reduce confusion
…art converting samples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me, and I think this should be the way to go.
While I think Thoai had comments about we should have a more clear main function body. As an example, we can have a static function to contains the build steps in the sample file instead of the util command, so that the main function body only contains the simple function call as before.
It would be good to have more team member look at it.
… line into a single function call
samples/Mqtt5/SharedSubscription/src/main/java/sharedsubscription/SharedSubscription.java
Outdated
Show resolved
Hide resolved
Update 04/07/2023: Removed the |
Thanks! Merging into |
Description of changes:
Refactors samples not to rely on
cmdUtils
to setup MQTT clients, to connect/disconnect for connect samples, and overall just makescmdUtils
go back to command line parsing and nothing more.Also contains the following minor changes:
Identity
toFleetProvisioning
for better visibility. Added note both in README and sample itself thatIdentity
=FleetProvisioning
PubSubStress
sample entirelyca
being used in a couple samples instead ofca_file
.import
calls in all samples to just those that are needed.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.