load-test: fix failing tests due to role session timeout, clean up code #676
Conversation
| @@ -52,21 +52,13 @@ phases: | |||
| - python -m venv venv | |||
| - source venv/bin/activate | |||
| - pip install -r ./load_tests/requirements.txt | |||
| # AWS configure sts temp credentials | |||
There was a problem hiding this comment.
You may wonder, why did he remove this? Is this safe?
In load tests, everything runs via the python script, and as you can see in the other code changes, that code assumes the LOAD_TEST_CFN_ROLE_ARN role itself. This means we were previously unnecessarily chaining sessions (buildspec assumes the role, then the python uses that role to assume the same role).
| # wait for tasks and validate | ||
| for input_logger in INPUT_LOGGERS: |
There was a problem hiding this comment.
This change should speed up the tests slightly. If you read the lines above and below here, we first start the tasks for each input (tcp vs stdout) and then validate... but each of our tests uses a unique resource (log stream, firehose, kinesis, etc) for each test... so there's no reason why we can't start all of them first and then loop over them and check for results.
Signed-off-by: Wesley Pettit <[email protected]>
PettitWesley
force-pushed
the
role-timeout
branch
from
9e2a2dc to
9b13afb
Compare
| session = get_sts_boto_session() | ||
|
|
||
| client = session.client('ecs') | ||
| waiter = client.get_waiter('tasks_stopped') | ||
|
|
||
| processes = [] | ||
|
|
There was a problem hiding this comment.
Do we till need this for loop after logic change? I don't understand what's the work for this for-loop.
At least should we remove processes = [] out of the for loop?
There was a problem hiding this comment.
oh you're right, thanks, processes needs to move to below.
There was a problem hiding this comment.
This for loop runs the tasks, then 2nd one validates.
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.