Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 2.29.0 #489

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Bump to 2.29.0 #489

merged 1 commit into from
Dec 6, 2022

Conversation

matthewfala
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@matthewfala matthewfala requested a review from a team as a code owner December 5, 2022 20:39
@matthewfala matthewfala force-pushed the bump-2.29.0 branch 2 times, most recently from d85add3 to a34236b Compare December 5, 2022 20:46
CHANGELOG.md Outdated
Compared to `2.28.4` this release adds:
* Feature - Add `store_dir_limit_size` option [fluent-bit-docs:971](https://github.com/fluent/fluent-bit-docs/pull/971)
* Feature - New filter for AWS ECS Metadata [fluentbit:5898](https://github.com/fluent/fluent-bit/pull/5898)
* Enhancement - Resolve Fluent Bit networking hangs affecting CloudWatch plugin by migrating to async networking + sync core scheduler [fluent-bit:6339](https://github.com/fluent/fluent-bit/pull/6339)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this hsould be called out as a Bug entry

CHANGELOG.md Outdated
Compared to `2.28.4` this release adds the following feature that we are working on getting accepted upstream:

* Feature - Kinesis FireHose and Streams nanoseconds and milliseconds `time_key_format` support [fluentbit:2831](https://github.com/fluent/fluent-bit/issues/2831)
* Bug - Use log timestamp as s3 file timestamp [aws-for-fluent-bit:460](https://github.com/aws/aws-for-fluent-bit/issues/460)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Use log timestamp for s3 key timestamp is more clear IMO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks

PettitWesley
PettitWesley previously approved these changes Dec 5, 2022
@PettitWesley PettitWesley self-requested a review December 5, 2022 21:36
@PettitWesley PettitWesley dismissed their stale review December 5, 2022 21:37

clay's PRs are not ready yet

Copy link
Contributor

@PettitWesley PettitWesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this merge until @Claych PRs are approved and tested. If we want to still release, we need to remove those cherry picks.

@matthewfala matthewfala force-pushed the bump-2.29.0 branch 3 times, most recently from 6c0c3f6 to 8587f96 Compare December 6, 2022 20:01
@matthewfala
Copy link
Contributor Author

@PettitWesley I split the release commits.

2.29.0 -> Fluent Bit 1.9.10 with no cherry-picks
2.29.1 -> Fluent Bit 1.9.10 with cherry-picks

Please see 2.29.1 for the cherry-picks
#490

This way if the cherry-picked code has unforseen issues we'll still have a stable image with the cloudwatch hang resolution. Working with Clay on testing the changes

Copy link
Contributor

@PettitWesley PettitWesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewfala Good idea 💪, splitting up many changes into two releases; I should've thought of that myself.

@matthewfala matthewfala merged commit ed603e3 into aws:mainline Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants