-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init: add multiline_parser #486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@konoui Thank You!
Next step: Someone from our team needs to pull this change and test it before we merge. @matthewfala @Claych
Sorry we have neglected this. I will work on running the integ test soon. |
@PettitWesley |
@kakakakakku I apologize, this has been on my backlog for a while, but I've been backed up with different high impact issues/bugs/fixes. I've bumped the priority on my backlog for this... sorry that's all I can do for now :( |
Is there any chance to get this merged? We had to build a custom image with the workaround described at #537 (comment). It is not a big deal but we prefer to have this feature in the init tag image by default. Thank you. |
I completed testing with the following. I checked that the files were downloaded and that FLB started up and ran and checked the entrypoint.
Resulting entrypoint:
|
Thanks @konoui and apologies that we took soooo long to merge this! |
Issue #, if available:
#537
Description of changes:
The init process should handle MULTILINE_PARSER in the same way as PARSER.
Currently, a validation error will occur in fluent bit.
https://github.com/fluent/fluent-bit/blob/v2.0.5/src/fluent-bit.c#L862
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.