-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 2.20.0 #250
Conversation
CHANGELOG.md
Outdated
Compared to `2.19.2` this release adds: | ||
* Feature - Add support for gzip compression of records [kinesis:162](https://github.com/aws/amazon-kinesis-streams-for-fluent-bit/pull/162) | ||
* Bug - Fix return value from `tls_net_read` [fluentbit:4100](https://github.com/fluent/fluent-bit/pull/4100) | ||
* Bug - Downgrade `mbedtls` to 2.24.0 [firelens:249](https://github.com/aws/aws-for-fluent-bit/pull/249) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[firelens:249]
firelens isn't the repo name... aws-for-fluent-bit
would make more sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, I think we should add something saying why we did this? Like say its because it improves performance. Ramya can help with the wording
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For mbedtls, link to the github issue fluent/fluent-bit#4110. Wording will be: Revert to mbedtls 2.24.0 because mbedtls 2.26.0 introduces performance regression in the function used to encode the request to AWS destinations in base64 format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Let me update to this
CHANGELOG.md
Outdated
* Bug - Downgrade `mbedtls` to 2.24.0 [firelens:249](https://github.com/aws/aws-for-fluent-bit/pull/249) | ||
|
||
Important Note: | ||
* Besides upgrading Fluent Bit version to 1.8.7, we also include some customized changes with this latest version (2.20.0) of `aws-for-fluent-bit` image. It aims to fix the `openssl` issue in Fluent Bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we have two changes, how about just "This aims to fix performance and stability issues in Fluent Bit"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Don't call it the openssl issue since it is actually an issue in the way fluent-bit uses openssl apis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Versions look good. Commented on the release notes wording.
Issue #, if available:
Description of changes:
Bump version to 2.20.0
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.