Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 2.20.0 #250

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Bump version to 2.20.0 #250

merged 1 commit into from
Oct 1, 2021

Conversation

zhonghui12
Copy link
Contributor

Issue #, if available:

Description of changes:
Bump version to 2.20.0

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zhonghui12 zhonghui12 requested a review from a team as a code owner September 30, 2021 23:55
CHANGELOG.md Outdated
Compared to `2.19.2` this release adds:
* Feature - Add support for gzip compression of records [kinesis:162](https://github.com/aws/amazon-kinesis-streams-for-fluent-bit/pull/162)
* Bug - Fix return value from `tls_net_read` [fluentbit:4100](https://github.com/fluent/fluent-bit/pull/4100)
* Bug - Downgrade `mbedtls` to 2.24.0 [firelens:249](https://github.com/aws/aws-for-fluent-bit/pull/249)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[firelens:249]

firelens isn't the repo name... aws-for-fluent-bit would make more sense

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, I think we should add something saying why we did this? Like say its because it improves performance. Ramya can help with the wording

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For mbedtls, link to the github issue fluent/fluent-bit#4110. Wording will be: Revert to mbedtls 2.24.0 because mbedtls 2.26.0 introduces performance regression in the function used to encode the request to AWS destinations in base64 format.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Let me update to this

CHANGELOG.md Outdated
* Bug - Downgrade `mbedtls` to 2.24.0 [firelens:249](https://github.com/aws/aws-for-fluent-bit/pull/249)

Important Note:
* Besides upgrading Fluent Bit version to 1.8.7, we also include some customized changes with this latest version (2.20.0) of `aws-for-fluent-bit` image. It aims to fix the `openssl` issue in Fluent Bit.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we have two changes, how about just "This aims to fix performance and stability issues in Fluent Bit"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Don't call it the openssl issue since it is actually an issue in the way fluent-bit uses openssl apis.

Copy link

@krispraws krispraws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versions look good. Commented on the release notes wording.

@zhonghui12 zhonghui12 merged commit 32d9f9b into aws:mainline Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants