-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dafny-rust): setup and test check-in polymorph rust code (commented out for now); fix windows tests #688
Merged
RitvikKapila
merged 29 commits into
rkapila/rust-reviewed
from
rkapila/checkin-smithy-rust
Oct 29, 2024
Merged
chore(dafny-rust): setup and test check-in polymorph rust code (commented out for now); fix windows tests #688
RitvikKapila
merged 29 commits into
rkapila/rust-reviewed
from
rkapila/checkin-smithy-rust
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RitvikKapila
changed the title
chore(dafny-rust): check-in polymorph rust code
chore(dafny-rust): check-in polymorph rust code; fix windows tests
Oct 27, 2024
ajewellamz
approved these changes
Oct 29, 2024
ajewellamz
approved these changes
Oct 29, 2024
RitvikKapila
changed the title
chore(dafny-rust): check-in polymorph rust code; fix windows tests
chore(dafny-rust): setup and test check-in polymorph rust code (commented out for now); fix windows tests
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Setup and test checking in polymorph rust code
This MAY be enabled depending on if patching works after adding polymorph code to gitignore, this PR confirms that it works and also tests that.
After this PR merges, tests on windows MUST pass
Verification is expected to fail and is being fixed by this PR to main: #690
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.