chore: Rename EncryptionSdk Dafny module name #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
This reverts commit bed53f4.
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
rishav-karanjit
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Change the Dafny name for EncryptionSdk client to ESDK.
Both Go and Python will reference every Local Service client module name as the localService trait's sdkId value. Old PR in MPL for same issue: chore: Rename AtomicPrimitives Dafny module name aws-cryptographic-material-providers-library#589.
This changes EncryptionSdk' Dafny name to align with its localService trait sdkId value.
(There is no change for Rust/NET compiled code here because this module uses an extern in those languages.)
Squash/merge commit message, if applicable:
How did I test this?
In the CI.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.