feat: add user agent to default KMS clients #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-chew
commented
Jul 12, 2022
|
|
||
| [assembly: AssemblyTitle("AWS.EncryptionSDK")] | ||
|
|
||
| // This should be kept in sync with the version number in AWSEncryptionSDK.csproj |
There was a problem hiding this comment.
Modern .NET versions allow to generate this assembly metadata automatically (e.g. derive AssemblyVersion from Version), so that we wouldn't need to manually keep these in sync. But so long as we support .NET Framework, AFAICT there isn't an automated mechanism to avoid this duplication.
ajewellamz
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: Adds a
AwsEncryptionSdkNet/x.y.zuser agent to KMS clients vended by the default client supplier. Adding the user agent to other KMS calls (including in single-key keyrings) is left as later work.This was tested by running the AWS KMS multi-keyring example and checking that the desired user agent appears in the CloudTrail logs for the corresponding KMS actions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.