Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Java, .NET): Let the MPL define dependencies #1473

Closed
wants to merge 2 commits into from

Conversation

texastony
Copy link
Contributor

Issue #, if available:

Description of changes:
Normally, if a package directly uses classes/objects/references/symbols from an other package,
it should declare a direct dependency on that package,
rather than relying on it being in the symbol resolution via a transitive dependency.

However,
the DB-ESDK and the MPL are strongly linked.
Additionally,
they are owned/maintained by the same team,
AWS Crypto Tools.

AWS Crypto Tools can reduce the amount of effort needed
to update the KMS, DDB, Bouncy Castle, and other dependencies
common to both the MPL and the DB-ESDK by breaking the convention
described above.

This helps our customers by reducing Crypto Tools maintenance efforts,
freeing us to innovate or investigate issues.

Closes #1470

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@texastony texastony requested a review from a team as a code owner November 7, 2024 17:19
@texastony
Copy link
Contributor Author

Alas, Dependency resolution in Java and .NET does not work as I thought it.
The MPL's Dependencies are runtime dependencies.
But the DB-ESDK needs them to compile.

If Crypto Tools wants to do something,
we will have to determine a more elaborate solution,
likely using native features of Java, .NET, and any future runtime
to duplicate the information.

@texastony texastony closed this Nov 7, 2024
@texastony texastony deleted the tony/fix-no-mpl-transitive-deps branch November 7, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants