Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump to MPL HEAD, Smithy-Dafny HEAD #1299

Merged
merged 72 commits into from
Nov 1, 2024
Merged

Conversation

lucasmcdonald3
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 commented Aug 21, 2024

Issue #, if available:

Description of changes:

  • Bump to MPL HEAD
  • Fix shared cache verification
  • Bump to Smithy-Dafny HEAD
  • Repolymorph
  • Rename Aws.Cryptography.Primitives to AtomicPrimitives
  • Change Dafny formatter from hard-coded 4.2.0 to CI's Dafny version
  • Run Dafny formatter

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lucasmcdonald3 lucasmcdonald3 changed the title primitives name chore: Rename AtomicPrimitives Dafny module name Aug 21, 2024
@lucasmcdonald3 lucasmcdonald3 changed the title chore: Rename AtomicPrimitives Dafny module name [BLOCKS MPL 1.5.2+ UPGRADE] chore: Rename AtomicPrimitives Dafny module name Aug 23, 2024
@lucasmcdonald3 lucasmcdonald3 changed the title [BLOCKS MPL 1.5.2+ UPGRADE] chore: Rename AtomicPrimitives Dafny module name chore: Rename AtomicPrimitives Dafny module name Sep 24, 2024
seebees
seebees previously approved these changes Oct 2, 2024
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lucasmcdonald3 and others added 5 commits October 29, 2024 11:47
Use the provided cache.

Calling `mpl.CreateCryptographicMaterialsCache`
with a `Shared` cache will result in an error.

Update the testing to
ensure that no shared cache is passed.
@lucasmcdonald3 lucasmcdonald3 changed the title chore: Rename AtomicPrimitives Dafny module name chore: Bump to MPL HEAD, Smithy-Dafny HEAD Oct 31, 2024
@lucasmcdonald3 lucasmcdonald3 marked this pull request as ready for review October 31, 2024 18:59
@lucasmcdonald3 lucasmcdonald3 requested a review from a team as a code owner October 31, 2024 18:59
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucasmcdonald3 lucasmcdonald3 merged commit b2674a9 into main Nov 1, 2024
49 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants