-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump to MPL HEAD, Smithy-Dafny HEAD #1299
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmcdonald3
changed the title
primitives name
chore: Rename AtomicPrimitives Dafny module name
Aug 21, 2024
lucasmcdonald3
changed the title
chore: Rename AtomicPrimitives Dafny module name
[BLOCKS MPL 1.5.2+ UPGRADE] chore: Rename AtomicPrimitives Dafny module name
Aug 23, 2024
* chore: add ddb local to dafny interop test vectors * bump setup-dafny
Co-authored-by: semantic-release-bot <[email protected]>
lucasmcdonald3
changed the title
[BLOCKS MPL 1.5.2+ UPGRADE] chore: Rename AtomicPrimitives Dafny module name
chore: Rename AtomicPrimitives Dafny module name
Sep 24, 2024
seebees
previously approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Use the provided cache. Calling `mpl.CreateCryptographicMaterialsCache` with a `Shared` cache will result in an error. Update the testing to ensure that no shared cache is passed.
lucasmcdonald3
changed the title
chore: Rename AtomicPrimitives Dafny module name
chore: Bump to MPL HEAD, Smithy-Dafny HEAD
Oct 31, 2024
seebees
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Aws.Cryptography.Primitives
toAtomicPrimitives
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.