-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix nightly build (aside from verification) #1029
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texastony
requested changes
May 16, 2024
...aphy/dbencryptionsdk/dynamodb/itemencryptor/internaldafny/legacy/InternalLegacyOverride.java
Outdated
Show resolved
Hide resolved
…amodb-java into robin-aws/fix-nightly-build-2024-05-15 # Conflicts: # DynamoDbEncryption/runtimes/java/src/main/java/software/amazon/cryptography/dbencryptionsdk/dynamodb/itemencryptor/internaldafny/legacy/InternalLegacyOverride.java
…amodb-java into robin-aws/fix-nightly-build-2024-05-15 # Conflicts: # DynamoDbEncryption/runtimes/net/DynamoDbEncryption.csproj # project.properties
seebees
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
texastony
approved these changes
Jun 4, 2024
rishav-karanjit
pushed a commit
that referenced
this pull request
Jul 12, 2024
## [3.5.1](v3.5.0...v3.5.1) (2024-07-12) ### Maintenance * bump dafny verification version to 4.7 ([#1181](#1181)) ([e7801ec](e7801ec)) * Fix nightly build (aside from verification) ([#1029](#1029)) ([862420e](862420e)) * **GHA:** add action for testing against MPL HEAD ([#1187](#1187)) ([b2f70ca](b2f70ca)) * **GHA:** fix daily ci ([#1194](#1194)) ([a1427e0](a1427e0)) * update project.properties to be SNAPSHOT ([#1087](#1087)) ([6f2825e](6f2825e))
ajewellamz
pushed a commit
that referenced
this pull request
Jul 23, 2024
## [3.6.0](v3.5.0...v3.6.0) (2024-07-23) ### Features * allow indirect attribute names with MultiKeyStore ([#1208](#1208)) ([4ab97bc](4ab97bc)) ### Maintenance * bump dafny verification version to 4.7 ([#1181](#1181)) ([e7801ec](e7801ec)) * **CI/CD:** use latest conventional-changelog-conventionalcommits ([#1195](#1195)) ([510227e](510227e)) * Fix nightly build (aside from verification) ([#1029](#1029)) ([862420e](862420e)) * **GHA:** add action for testing against MPL HEAD ([#1187](#1187)) ([b2f70ca](b2f70ca)) * **GHA:** fix daily ci ([#1194](#1194)) ([a1427e0](a1427e0)) * **MPL:** Bump MPL to 1.5.1 ([#1201](#1201)) ([808a5b4](808a5b4)) * Sonatype Migration to User Tokens ([#1216](#1216)) ([a3b4ef9](a3b4ef9)) * Try to update existing issues ([31c6b98](31c6b98)) * Try to update existing issues ([4471295](4471295)) * update project.properties to be SNAPSHOT ([#1087](#1087)) ([6f2825e](6f2825e))
Merged
ajewellamz
added a commit
that referenced
this pull request
Jul 23, 2024
* chore(release): 3.6.0 ## [3.6.0](v3.5.0...v3.6.0) (2024-07-23) ### Features * allow indirect attribute names with MultiKeyStore ([#1208](#1208)) ([4ab97bc](4ab97bc)) ### Maintenance * bump dafny verification version to 4.7 ([#1181](#1181)) ([e7801ec](e7801ec)) * **CI/CD:** use latest conventional-changelog-conventionalcommits ([#1195](#1195)) ([510227e](510227e)) * Fix nightly build (aside from verification) ([#1029](#1029)) ([862420e](862420e)) * **GHA:** add action for testing against MPL HEAD ([#1187](#1187)) ([b2f70ca](b2f70ca)) * **GHA:** fix daily ci ([#1194](#1194)) ([a1427e0](a1427e0)) * **MPL:** Bump MPL to 1.5.1 ([#1201](#1201)) ([808a5b4](808a5b4)) * Sonatype Migration to User Tokens ([#1216](#1216)) ([a3b4ef9](a3b4ef9)) * Try to update existing issues ([31c6b98](31c6b98)) * Try to update existing issues ([4471295](4471295)) * update project.properties to be SNAPSHOT ([#1087](#1087)) ([6f2825e](6f2825e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Makes the same changes around avoiding direct calls to instantiate parameterized datatypes in Java code as in aws/aws-cryptographic-material-providers-library#195, plus some CI configuration fixes.
Dry runs of nightly builds:
Will leave fixing the verification for a separate PR since this was already a fair bit of work :)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.