Skip to content

Commit

Permalink
fix(SearchableEncryption): disable shared cached (#1507)
Browse files Browse the repository at this point in the history
Co-authored-by: Ritvik Kapila <[email protected]>
  • Loading branch information
texastony and RitvikKapila authored Dec 16, 2024
1 parent 7b45929 commit ffc67be
Showing 1 changed file with 18 additions and 1 deletion.
19 changes: 18 additions & 1 deletion DynamoDbEncryption/dafny/DynamoDbEncryption/src/ConfigToInfo.dfy
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,23 @@ module SearchConfigToInfo {
&& config.multi.keyFieldName in outer.attributeActionsOnEncrypt
&& outer.attributeActionsOnEncrypt[config.multi.keyFieldName] == SE.ENCRYPT_AND_SIGN
==> output.Failure?
// Not in Spec, but for now, SE does not support the Shared Cache Type
ensures
&& config.multi?
&& config.multi.cache.Some?
&& config.multi.cache.value.Shared?
==>
&& output.Failure?
// If the failure was NOT caused by booting up the MPL
&& !output.error.AwsCryptographyMaterialProviders?
==>
&& output.error.DynamoDbEncryptionException?
&& output.error.message == "Searchable Encryption does not support the Shared Cache type at this time."
{
// TODO-FutureCleanUp : https://github.com/aws/aws-database-encryption-sdk-dynamodb/issues/1510
// It is not-good that the MPL is initialized here;
// The MPL has a config object that could hold customer intent that affects behavior.
// Today, it does not. But tomorrow?
var mplR := MaterialProviders.MaterialProviders();
var mpl :- mplR.MapFailure(e => AwsCryptographyMaterialProviders(e));

Expand All @@ -139,7 +155,8 @@ module SearchConfigToInfo {

var cache;
if cacheType.Shared? {
cache := cacheType.Shared;
return Failure(DynamoDbEncryptionException(message:="Searchable Encryption does not support the Shared Cache type at this time."));
// cache := cacheType.Shared;
} else {
//= specification/searchable-encryption/search-config.md#key-store-cache
//# For a Beacon Key Source a [CMC](../../submodules/MaterialProviders/aws-encryption-sdk-specification/framework/cryptographic-materials-cache.md)
Expand Down

0 comments on commit ffc67be

Please sign in to comment.