Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Consolidate tasks #99

Merged
merged 6 commits into from
Oct 20, 2023
Merged

chore: Consolidate tasks #99

merged 6 commits into from
Oct 20, 2023

Conversation

seebees
Copy link
Contributor

@seebees seebees commented Oct 19, 2023

  • Update the root Makefile to run for each library
  • Add format and codegen targets to root Makefile
  • Add java and net format/check targets
  • Update format action to prepare for update

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@seebees seebees requested a review from a team as a code owner October 19, 2023 17:02
texastony
texastony previously approved these changes Oct 19, 2023
* Update the root Makefile to run for each library
* Add format and codegen targets to root Makefile
* Add java and net format/check targets
* Update format action to prepare for update
@seebees seebees force-pushed the ryanemer/consolidate-tasks branch from f1118a9 to b265bc9 Compare October 19, 2023 17:45
@seebees seebees temporarily deployed to Duvet CI October 19, 2023 17:46 — with GitHub Actions Inactive
@seebees seebees temporarily deployed to Duvet CI October 19, 2023 18:08 — with GitHub Actions Inactive
@seebees seebees temporarily deployed to Duvet CI October 19, 2023 20:38 — with GitHub Actions Inactive
@seebees seebees temporarily deployed to Duvet CI October 19, 2023 20:39 — with GitHub Actions Inactive
@seebees seebees temporarily deployed to Duvet CI October 19, 2023 22:43 — with GitHub Actions Inactive
@seebees seebees temporarily deployed to Duvet CI October 19, 2023 22:55 — with GitHub Actions Inactive
@@ -13,7 +13,7 @@ on:

jobs:
manual-ci-format:
uses: ./.github/workflows/library_dafny_format.yml
uses: ./.github/workflows/library_format.yml
with:
dafny: '4.2.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to pull these Dafny Version variables out to a common definition!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree.

@seebees seebees merged commit 0b39992 into main Oct 20, 2023
45 checks passed
@seebees seebees deleted the ryanemer/consolidate-tasks branch October 20, 2023 16:27
ajewellamz pushed a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants