fix: Move Java helper methods out of extern class #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robin-aws @josecorella This Branch is failing the "does not break DB-ESDK" check: Question: @josecorella Did I run the check correctly? |
texastony
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Blocking until we figure out if this works with DB-ESDK or not.
https://github.com/aws/aws-database-encryption-sdk-dynamodb/actions/runs/11333537614/job/31517906552
|
Tried again with the a newer manual workflow: https://github.com/aws/aws-database-encryption-sdk-dynamodb/actions/runs/11333611590 |
|
Thanks @texastony! @josecorella would it be doable to run the "does not break DB-ESDK" check in the CI of this project? |
robin-aws
deleted the
robin-aws/avoid-static-functions-in-extern-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I added these as a migration workaround for upgrading the Dafny version, but as a side effect it made
HMaca mixed Dafny/native class when it wasn't intended to be, and this isn't supported on all target languages (e.g. Go). Easy fix to move them out of the class to the surrounding module instead.Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.