Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add documentation to externs #590

Merged
merged 3 commits into from
Aug 13, 2024
Merged

chore: add documentation to externs #590

merged 3 commits into from
Aug 13, 2024

Conversation

ajewellamz
Copy link
Contributor

Issue #, if available:

Description of changes:

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ajewellamz ajewellamz requested a review from a team as a code owner August 13, 2024 14:24
Copy link
Contributor

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits and a question

AwsCryptographyPrimitives/src/Digest.dfy Show resolved Hide resolved
AwsCryptographyPrimitives/src/ECDH.dfy Outdated Show resolved Hide resolved
AwsCryptographyPrimitives/src/ECDH.dfy Outdated Show resolved Hide resolved
AwsCryptographyPrimitives/src/ECDH.dfy Outdated Show resolved Hide resolved
AwsCryptographyPrimitives/src/ECDH.dfy Outdated Show resolved Hide resolved
AwsCryptographyPrimitives/src/ECDH.dfy Outdated Show resolved Hide resolved
AwsCryptographyPrimitives/src/ECDH.dfy Outdated Show resolved Hide resolved
AwsCryptographyPrimitives/src/Signature.dfy Outdated Show resolved Hide resolved
AwsCryptographyPrimitives/src/Signature.dfy Outdated Show resolved Hide resolved
AwsCryptographyPrimitives/src/Signature.dfy Outdated Show resolved Hide resolved
Copy link
Contributor

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ajewellamz ajewellamz merged commit bd44ca8 into main Aug 13, 2024
70 checks passed
@ajewellamz ajewellamz deleted the ajewell/docs branch August 13, 2024 19:20
texastony pushed a commit that referenced this pull request Aug 23, 2024
* chore: add documentation to externs
lucasmcdonald3 pushed a commit that referenced this pull request Aug 29, 2024
* chore: add documentation to externs
lucasmcdonald3 pushed a commit that referenced this pull request Sep 24, 2024
* chore: add documentation to externs
lucasmcdonald3 pushed a commit to lucasmcdonald3/aws-cryptographic-material-providers-library that referenced this pull request Sep 26, 2024
* chore: add documentation to externs
lucasmcdonald3 pushed a commit to lucasmcdonald3/aws-cryptographic-material-providers-library that referenced this pull request Oct 1, 2024
* chore: add documentation to externs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants