Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Keystore): assert that lying branch keys are rejected #398

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

texastony
Copy link
Contributor

@texastony texastony commented Jun 11, 2024

Issue #, if available:

Description of changes:

The Keystore's threat model protects against malicious actors with write access to the backing Keystore Table.
In particular, the Keystore's implementation assures that a Branch Key's DynamoDB Item correctly describes the KMS ARN used to Generate the Branch Key Materials.
This additional test validates this mitigation.

This is an additional, explicit, test of this already existing behavior/mitigation.

Squash/merge commit message, if applicable:

test(Keystore): assert that lying branch keys are rejected

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@texastony texastony marked this pull request as ready for review June 11, 2024 01:09
@texastony texastony requested a review from a team as a code owner June 11, 2024 01:09
Co-authored-by: Andrew Jewell <[email protected]>
Copy link
Contributor

@ajewellamz ajewellamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@texastony texastony merged commit c5b961b into main Jun 11, 2024
57 checks passed
@texastony texastony deleted the tony/test-keystore-branch-key-lies-about-kms-arn branch June 11, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants