feat: repolymorph to get dotnet constraint checking #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robin-aws Do you know why the properties files were added in this PR? |
|
Yes please do remove them, we shouldn't have them committed since these repos use a top-level project.properties instead. This is a side-effect of the consolidation into a single shared makefile: the smithy-dafny TestModels need the per-library copy emitted in order to build. I'll see if there's a quick patch to smithy-dafny to make that happen ONLY in the TestModels scope. |
kessplas
pushed a commit
that referenced
this pull request
Apr 23, 2024
# [1.3.0](v1.2.0...v1.3.0) (2024-04-23) ### Bug Fixes * **dafny:** Local Service Constructors MUST return concrete ([64f72c1](64f72c1)) * dir name in java mpl release process ([#162](#162)) ([d92c06a](d92c06a)) * Re-Polymorph w/ Smithy-Dafny@3378be16 & fix Java Testing ([#190](#190)) ([58d74f6](58d74f6)) ### Features * enable KMS MRK Keys in KeyStore ([#285](#285)) ([d924395](d924395)) * remove quantifier-syntax ([#218](#218)) ([76ab6ef](76ab6ef)) * repolymorph to get dotnet constraint checking ([#281](#281)) ([04102d7](04102d7))
lucasmcdonald3
pushed a commit
that referenced
this pull request
Apr 24, 2024
# [1.3.0](v1.2.0...v1.3.0) (2024-04-24) ### Bug Fixes * **dafny:** Local Service Constructors MUST return concrete ([64f72c1](64f72c1)) * dir name in java mpl release process ([#162](#162)) ([d92c06a](d92c06a)) * **KeyStore:** JavaDocs for KMS Configuration ([#293](#293)) ([63ffff5](63ffff5)) * Re-Polymorph w/ Smithy-Dafny@3378be16 & fix Java Testing ([#190](#190)) ([58d74f6](58d74f6)) ### Features * enable KMS MRK Keys in KeyStore ([#285](#285)) ([d924395](d924395)) * remove quantifier-syntax ([#218](#218)) ([76ab6ef](76ab6ef)) * repolymorph to get dotnet constraint checking ([#281](#281)) ([04102d7](04102d7))
Merged
lucasmcdonald3
pushed a commit
that referenced
this pull request
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.