Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Empty string defers to SDK default region #127

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

seebees
Copy link
Contributor

@seebees seebees commented Nov 16, 2023

The ESDK will pass an empty string
as the AWS region in cases where no region is know.

In this case we defer to the SDK
on how to evaluate the default region.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The ESDK will pass an empty string
as the AWS region in cases where no region is know.

In this case we defer to the SDK
on how to evaluate the default region.
@seebees seebees requested a review from a team as a code owner November 16, 2023 19:09
Copy link
Contributor

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seebees seebees merged commit 3bd13b6 into main Nov 16, 2023
46 checks passed
@seebees seebees deleted the ryanemer/default-kms-region branch November 16, 2023 22:12
ajewellamz pushed a commit that referenced this pull request Dec 18, 2024
* feat: SimpleInteger Tests

* fix: README

* chore: Use shared makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants